Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.7 #1179

Merged
merged 17 commits into from
Mar 7, 2024
Merged

v1.2.7 #1179

merged 17 commits into from
Mar 7, 2024

Conversation

manav2401
Copy link
Contributor

Description

Merge latest release v1.2.7 to master

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

anshalshukla and others added 17 commits January 29, 2024 19:55
FromBig returns true *when overflow occurs*
…mmittedState function to fix 'concurrent map writes' (#1176)
* eth, core: track block announcement and import timings

* eth: track total delay

* eth: add more context and prefix in logs

* eth/fetcher: fix invalid tracking of received at time

* put logs behind log.enable-block-tracking flag

* fix lint

* improve logging

* add comments

* add comments
This change will check commit interrupt signal coming from other channels, e.g. newHead, reSubmit, before checking transaction level interrupt. This is to fix a corner case where an interrupt signal coming from another channel getting intercepted by transaction level interrupt, which resulted in an uncleaned state (potentially deadlock).
@manav2401 manav2401 requested a review from a team March 6, 2024 11:25
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 50.37037% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 55.92%. Comparing base (812ccb0) to head (564981b).

Files Patch % Lines
eth/fetcher/block_fetcher.go 62.50% 20 Missing and 1 partial ⚠️
eth/backend.go 0.00% 13 Missing ⚠️
internal/cli/bootnode.go 0.00% 9 Missing ⚠️
miner/worker.go 20.00% 3 Missing and 5 partials ⚠️
core/types/transaction_marshalling.go 0.00% 7 Missing ⚠️
eth/handler.go 75.00% 5 Missing ⚠️
eth/bor_checkpoint_verifier.go 0.00% 2 Missing ⚠️
eth/protocols/eth/handlers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
- Coverage   55.95%   55.92%   -0.04%     
==========================================
  Files         658      658              
  Lines      114440   114481      +41     
==========================================
- Hits        64040    64020      -20     
- Misses      46541    46616      +75     
+ Partials     3859     3845      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manav2401 manav2401 merged commit 753c57e into master Mar 7, 2024
15 of 17 checks passed
@manav2401 manav2401 deleted the v1.2.7-candidate branch March 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants