Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bootnode #1149

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: bootnode #1149

merged 2 commits into from
Jan 30, 2024

Conversation

anshalshukla
Copy link
Contributor

@anshalshukla anshalshukla commented Jan 29, 2024

Description

This fixes the bootnodes issue due to which the port mapping was getting done improperly. Added a helper function to export the logic from bootnodes binary, this won't require any update on bootnodes flag function incase there is a change from upstream.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

I tried connecting two nodes using the bootnode.

@anshalshukla anshalshukla requested review from 0xsharma, manav2401 and a team January 29, 2024 15:40
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (241af1f) 55.92% compared to head (0a3d419) 55.93%.

Files Patch % Lines
internal/cli/bootnode.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
+ Coverage   55.92%   55.93%   +0.01%     
==========================================
  Files         658      658              
  Lines      114440   114435       -5     
==========================================
+ Hits        63996    64010      +14     
+ Misses      46601    46575      -26     
- Partials     3843     3850       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshalshukla anshalshukla changed the base branch from master to develop January 30, 2024 05:03
@anshalshukla anshalshukla changed the base branch from develop to master January 30, 2024 05:03
@marcello33
Copy link
Contributor

Can you please spend a few words about the changes in the PR description?
Thanks

Copy link
Contributor

@0xsharma 0xsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@temaniarpit27 temaniarpit27 changed the base branch from master to v1.2.4-beta-candidate January 30, 2024 07:37
@temaniarpit27 temaniarpit27 merged commit e4e713c into v1.2.4-beta-candidate Jan 30, 2024
13 of 14 checks passed
@temaniarpit27 temaniarpit27 deleted the bootnode branch January 30, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants