Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.2.3 #1139

Merged
merged 52 commits into from
Jan 23, 2024
Merged

V1.2.3 #1139

merged 52 commits into from
Jan 23, 2024

Conversation

temaniarpit27
Copy link
Contributor

Description

v1.2.3

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

ulerdogan and others added 30 commits November 3, 2023 09:30
(cherry picked from commit fb89b61cdc2ccf6bda9f77f72315e01fa4ffb7d7)
(cherry picked from commit a8c0a2e05c7b6cafa16d296f91da8cb651bf9d46)
(cherry picked from commit c0554c0764a2c021689e8d73b36987b67c954f0c)
(cherry picked from commit 6c7028a9043f65f0a3596be4a429be4e03d0eb89)
(cherry picked from commit d245194e7724c2a7d153945cc86c9aa8d0b522b3)
(cherry picked from commit 066a31f6345c8a04a4ebf84efd8c80d87107e6d5)
(cherry picked from commit ec17e788ade3f43ded67c014f019770634f32a7c)
(cherry picked from commit f5b6d7e9954cae87348e21525210affda09297c1)
(cherry picked from commit 2820903f591365b17a4c3bdb36bd49ee2d84054c)
(cherry picked from commit 1be1875156e2a5a417801deb59546b167e5456c6)
(cherry picked from commit 21f4932c9bbb8664cf7b3e3c3602b6a48c747893)
(cherry picked from commit 98f10b0d5e358075d03b76834cd30c97f4fbdfe1)
(cherry picked from commit cec0b058115282168c5afc5197de3f6b5479dc4a)
* fix: set balance in blockalloc

* chg: don't update balance if not zero

* fix: lint

* fix logic, add test cases
internal/ethapi: fix GetTransactionReceiptsByBlock method
…1107)

* fix: from address

* add: unit test for GetTransactionReceiptsByBlock
Removed the check for milestoneID in the GetVoteOnHash()
anshalshukla and others added 19 commits January 12, 2024 20:45
add: EIP7217/PIP27 implementation and related test cases

---------

Co-authored-by: Ulaş Erdoğan <[email protected]>
* integration-tests: update ipc path on ci tests

* added devnetBorFlags in matic-cli-config.yml

---------

Co-authored-by: Pratik Patil <[email protected]>
internal/ethapi, graphql: fix call with state api
@temaniarpit27 temaniarpit27 requested a review from a team January 22, 2024 12:15
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (70bebc9) 55.97% compared to head (f1e0b1d) 55.95%.
Report is 1 commits behind head on master.

Files Patch % Lines
core/parallel_state_processor.go 41.02% 23 Missing ⚠️
miner/worker.go 48.00% 13 Missing ⚠️
internal/ethapi/api.go 58.33% 10 Missing ⚠️
consensus/bor/snapshot.go 0.00% 9 Missing ⚠️
consensus/bor/bor.go 0.00% 8 Missing ⚠️
core/types/block.go 0.00% 2 Missing ⚠️
graphql/graphql.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage   55.97%   55.95%   -0.03%     
==========================================
  Files         658      658              
  Lines      114436   114440       +4     
==========================================
- Hits        64054    64033      -21     
- Misses      46537    46567      +30     
+ Partials     3845     3840       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pratikspatil024 and others added 2 commits January 22, 2024 20:47
* should use Lock when mutating the flag

* same problem in MVHashMap.Write

* hole the rlock while reading WriteCell

---------

Co-authored-by: zhiqiangxu <[email protected]>
…1132)

* changed parallel universe HF to napoli HF

* integration-tests: update ipc path on ci tests (#1127)

* integration-tests: update ipc path on ci tests

* added devnetBorFlags in matic-cli-config.yml

---------

Co-authored-by: Pratik Patil <[email protected]>

* Revert "integration-tests: update ipc path on ci tests (#1127)"

This reverts commit 0660fac.

* using cancun for block-stm metadata instead of napoli

* added a check to verify tx dependencies and test cases

* fix in snapshot.chainConfig

* removed snapshot.*params.BorConfig using snapshot.chainConfig.Bor instead

* removed unnecessary if statement in ParallelStateProcessor.Process

* addressed comment

* small fix in commitTransactions

* dependency calculation bug fix in miner/worker.go

---------

Co-authored-by: Manav Darji <[email protected]>
Co-authored-by: Arpit Temani <[email protected]>
@manav2401 manav2401 merged commit 241af1f into master Jan 23, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants