Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eip7212 #1134

Merged
merged 19 commits into from
Jan 19, 2024
Merged

Eip7212 #1134

merged 19 commits into from
Jan 19, 2024

Conversation

anshalshukla
Copy link
Contributor

Description

Please provide a detailed description of what was done in this PR

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

ulerdogan and others added 16 commits November 3, 2023 09:30
(cherry picked from commit fb89b61cdc2ccf6bda9f77f72315e01fa4ffb7d7)
(cherry picked from commit a8c0a2e05c7b6cafa16d296f91da8cb651bf9d46)
(cherry picked from commit c0554c0764a2c021689e8d73b36987b67c954f0c)
(cherry picked from commit 6c7028a9043f65f0a3596be4a429be4e03d0eb89)
(cherry picked from commit d245194e7724c2a7d153945cc86c9aa8d0b522b3)
(cherry picked from commit 066a31f6345c8a04a4ebf84efd8c80d87107e6d5)
(cherry picked from commit ec17e788ade3f43ded67c014f019770634f32a7c)
(cherry picked from commit f5b6d7e9954cae87348e21525210affda09297c1)
(cherry picked from commit 2820903f591365b17a4c3bdb36bd49ee2d84054c)
(cherry picked from commit 1be1875156e2a5a417801deb59546b167e5456c6)
(cherry picked from commit 21f4932c9bbb8664cf7b3e3c3602b6a48c747893)
(cherry picked from commit 98f10b0d5e358075d03b76834cd30c97f4fbdfe1)
(cherry picked from commit cec0b058115282168c5afc5197de3f6b5479dc4a)
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fc30ae) 55.92% compared to head (fe8d879) 55.98%.
Report is 4 commits behind head on v1.2.3-candidate.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           v1.2.3-candidate    #1134      +/-   ##
====================================================
+ Coverage             55.92%   55.98%   +0.05%     
====================================================
  Files                   658      658              
  Lines                114436   114458      +22     
====================================================
+ Hits                  63997    64075      +78     
+ Misses                46588    46531      -57     
- Partials               3851     3852       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@temaniarpit27 temaniarpit27 merged commit a24f66a into v1.2.3-candidate Jan 19, 2024
13 checks passed
@temaniarpit27 temaniarpit27 deleted the eip7212 branch January 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants