Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi, graphql: fix call with state api #1133

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

manav2401
Copy link
Contributor

Description

Hotfix for v1.2.2. This PR fixes the CallWithState call which happens during state-sync processing by passing correct state to lower functions.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Tested on internal devnode

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@manav2401 manav2401 requested a review from a team January 19, 2024 11:20
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v1.2.3-candidate@4be8c0e). Click here to learn what that means.

❗ Current head f92c3c0 differs from pull request most recent head 077bd41. Consider uploading reports for the commit 077bd41 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##             v1.2.3-candidate    #1133   +/-   ##
===================================================
  Coverage                    ?   55.99%           
===================================================
  Files                       ?      658           
  Lines                       ?   114454           
  Branches                    ?        0           
===================================================
  Hits                        ?    64084           
  Misses                      ?    46514           
  Partials                    ?     3856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@temaniarpit27 temaniarpit27 merged commit c4e2a3f into v1.2.3-candidate Jan 19, 2024
9 of 10 checks passed
@temaniarpit27 temaniarpit27 deleted the manav/fix-eth-call branch January 19, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants