Chg: Changed the maximum automatic rewind length from 256 to 126 #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1129 +/- ##
===========================================
+ Coverage 56.01% 56.04% +0.03%
===========================================
Files 658 658
Lines 114494 114494
===========================================
+ Hits 64136 64171 +35
+ Misses 46498 46455 -43
- Partials 3860 3868 +8 ☔ View full report in Codecov by Sentry. |
anshalshukla
changed the title
anshalshukla
changed the title
* integration-tests: update ipc path on ci tests * added devnetBorFlags in matic-cli-config.yml --------- Co-authored-by: Pratik Patil <[email protected]>
* add : amoy flags and genesis * minor fix * add : amoy.json in internal/cli/server * disable : peer check in mining for Amoy * add : amoy genesis hash * add amoy testnet deployment entries * update : amoy genesis * fix typos * add : post london forks + burn contract * add : amoy genesis hash * bump : version meta to amoy (#1092) * add : amoy bootnodes * chg : maxpeers of amoy val to 3 from 1 * bump : version to v1.1.0-amoy-2 * add : amoychain worker restriction on peercount --------- Co-authored-by: sreevalsanmr <[email protected]>
|
Closing as this change has been picked in v1.2.4-beta-candidate and will be back merged to develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have changed the automatic rewind length in the situation of checkpoint or milestone mismatch
from 256 to 126 as we have TriesInMemory size of 128. Keeping it 256 could have unexpected output.