Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream from geth 1.13.5 #1106

Merged
merged 287 commits into from
Feb 16, 2024
Merged

Upstream from geth 1.13.5 #1106

merged 287 commits into from
Feb 16, 2024

Conversation

0xsharma
Copy link
Contributor

Description

This PR contains upstream from geth v1.13.5.

holiman and others added 30 commits August 22, 2023 09:37
The PR #26274 broke the evm statetest command a bit, in that it stopped spitting out the stateroot following a non-successful statetest-execution. 

This PR changes it back, so the stateroot is unconditionally output on stderr, and makes it so fuzzing works again.
Fixes an error in tests of internal/ethapi.
We're trying a new named pipe library, which should hopefully fix some occasional failures in CI.

---------

Co-authored-by: Felix Lange <[email protected]>
graphql: fix the panic of nil timer.Stop

Signed-off-by: jsvisa <[email protected]>
eth/catalyst: only enable full payload in dev mode
account/abi: conver if-else-if chain to tagged switch
Adds an option to disable fsync for database operations.
This is to make tests faster.

---------

Co-authored-by: Marius van der Wijden <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
* eth/catalyst: disable heartbeat for simulated beacon node

Signed-off-by: jsvisa <[email protected]>

* eth/catalyst: update

* eth/catalyst: disable heartbeat for tester

---------

Signed-off-by: jsvisa <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
Co-authored-by: Gary Rong <[email protected]>
* cmd, core, params: add support for the Holesky testnet

* cmd/devp2p: add support for holesky for the dns crawler
…#27976)

Just some minor optimizations I figured out a while ago. By using ReadBytes instead of
Bytes on the rlp stream, we can save the allocation of a temporary buffer for the typed tx
payload.

If kind == rlp.Byte, the size reported by Stream.Kind will be zero, but we need a buffer
of size 1 for ReadBytes. Since typed txs always have to be longer than 1 byte, we can just
return an error for kind == rlp.Byte.

There is a also a small change for Log: since the first three fields of Log are the ones that 
should appear in the canon encoding, we can simply ignore the remaining fields via 
struct tag. Doing this removes an indirection through the rlpLog type.

---------

Co-authored-by: Martin Holst Swende <[email protected]>
…e) (#27992)



Signed-off-by: jsvisa <[email protected]>
Co-authored-by: Jared Wasinger <[email protected]>
Copy link
Contributor

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xsharma 0xsharma merged commit efc14de into develop Feb 16, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.