Skip to content

Commit

Permalink
Merge pull request #1370 from maticnetwork/mardizzone/fixes
Browse files Browse the repository at this point in the history
Limit bytes during response body read
  • Loading branch information
marcello33 authored Oct 31, 2024
2 parents 9adec02 + f08f2ea commit 70f3205
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions consensus/bor/heimdall/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ var (
)

const (
stateFetchLimit = 50
apiHeimdallTimeout = 5 * time.Second
retryCall = 5 * time.Second
heimdallAPIBodyLimit = 128 * 1024 * 1024 // 128 MB
stateFetchLimit = 50
apiHeimdallTimeout = 5 * time.Second
retryCall = 5 * time.Second
)

type StateSyncEventsResponse struct {
Expand Down Expand Up @@ -455,8 +456,11 @@ func internalFetch(ctx context.Context, client http.Client, u *url.URL) ([]byte,
return nil, nil
}

// Limit the number of bytes read from the response body
limitedBody := http.MaxBytesReader(nil, res.Body, heimdallAPIBodyLimit)

// get response
body, err := io.ReadAll(res.Body)
body, err := io.ReadAll(limitedBody)
if err != nil {
return nil, err
}
Expand Down

0 comments on commit 70f3205

Please sign in to comment.