Add option to center all text, and display encryption time by default #89
Conversation
|
As a preview: 
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 95.71% 92.43% -3.28%
==========================================
Files 7 7
Lines 677 701 +24
==========================================
Hits 648 648
- Misses 29 53 +24
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hi, thanks for your PR and apologies for the long delay; this has been a rather busy time for me.
Could you please separate out the timestamp implementation from the centering change. Mixing several features into one PR makes this harder to review…
Also, I'm currently reluctant to change the default behaviour so I'd prefer that the defaults wouldn't change, at least for now.
Lastly, are the timestamp and passphrase actually diametrically opposed? It seems to me that someone might want to have both (or indeed neither).
| @@ -9,3 +9,4 @@ | |||
| test-output.json | |||
| /visual-snapshots | |||
| *.profraw | |||
| .idea/ | |||
There was a problem hiding this comment.
It's a small thing but editor specific files should be ignored in a global gitignore file and not per-repo.
I learned Rust from scratch and implemented the features I mentioned in #88. 😄
There's a breaking change I made, to replace the passphrase field (Passphrase: _____) with encryption time (Encrypted at XXXX) by default. The passphrase field can be restored with
-Poption.The reason I made this decision is that I think the vast majority of people don't write their passphrase directly on paper, resulting in wasted space being taken up. If you have any comments about this, please communicate with me.
Options added:
-c, --center- Center all text-P, --passphrase-field- Display passphrase field instead of timeCloses #88