Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major overhaul of Urchin #97

Merged
merged 6 commits into from
Dec 14, 2024
Merged

Conversation

AlDu2407
Copy link
Contributor

@AlDu2407 AlDu2407 commented Nov 3, 2024

  • Added TailwindCSS to Urchin.
  • Updated Makefile to download TailwindCSS (currently only Linux is supported)
  • Refactored templates to share similar logic between templates.
  • Redesigned UI for Urchin.
  • Added layout page shared between all sub pages.
  • Added dark mode support.
  • Added new renderHtml method to reduce duplicate code in go.
  • Added self-designed minimalistic 'sea urchin' favicon. :D
  • Added missing sites about and services.
  • Added Not Found handling if a resource is requested that is not present, displaying an error message while keeping the layout page.
  • Restructured static folder to include stylesheets, scripts and assets.

- Added TailwindCSS to Urchin.
- Updated Makefile to download TailwindCSS (currently only Linux is supported)
- Refactored templates to share similar logic between templates.
- Redesigned UI for Urchin.
- Added layout page shared between all sub pages.
- Added dark mode support.
- Added new `renderHtml` method to reduce duplicate code in go.
- Added self-designed minimalistic 'sea urchin' favicon. :D
- Added missing sites `about` and `services`.
- Added `Not Found` handling if a resource is requested that is not present, displaying an error message while keeping the layout page.
- Restructured `static` folder to include stylesheets, scripts and assets.
- Updated Makefile to use `wget` instead of `cURL` to download TailwindCSS
CLI.
- Removed `cURL` from Dockerfile installation.
@matheusgomes28
Copy link
Owner

Hey @AlDu2407 , I wonder if you ever got a chance to add wget to the image?

Btw I think it has curl, so you could work around downloading the stuff you need on CI:

cp -r migrations tests/helpers/
if [ ! -f tailwindcss ]; then \
	wget -q https://github.com/tailwindlabs/tailwindcss/releases/latest/download/tailwindcss-linux-x64 \
		&& chmod +x tailwindcss-linux-x64 \
		&& mv tailwindcss-linux-x64 tailwindcss; \
fi
/bin/sh: 2: wget: not found
make: *** [Makefile:3[7](https://github.com/matheusgomes28/urchin/actions/runs/11663344344/job/32471628007?pr=97#step:4:8): install-tailwindcss] Error 127

@AlDu2407
Copy link
Contributor Author

Hi @matheusgomes28 ,

is there a way for you to remove the line in the Dockerfile, that removes wget from the build image? I think afterwards the pipeline will succeed. And afterwards you should be able to review the entire code.


import "github.com/matheusgomes28/urchin/common"

templ makeNotFound() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we show the requested resource in the header text

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do later, not an issue


templ MakeNotFoundPage(links []common.Link) {
@MakeLayout("Not Found", links, makeNotFound())
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line all of these files at the end

views/post.templ Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
+ Make sure we download a particular version of tailwind.
+ Make sure we do a checksum on the binary.
Copy link
Owner

@matheusgomes28 matheusgomes28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheusgomes28 matheusgomes28 merged commit d915e1c into matheusgomes28:main Dec 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants