-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major overhaul of Urchin #97
Conversation
- Added TailwindCSS to Urchin. - Updated Makefile to download TailwindCSS (currently only Linux is supported) - Refactored templates to share similar logic between templates. - Redesigned UI for Urchin. - Added layout page shared between all sub pages. - Added dark mode support. - Added new `renderHtml` method to reduce duplicate code in go. - Added self-designed minimalistic 'sea urchin' favicon. :D - Added missing sites `about` and `services`. - Added `Not Found` handling if a resource is requested that is not present, displaying an error message while keeping the layout page. - Restructured `static` folder to include stylesheets, scripts and assets.
- Updated Makefile to use `wget` instead of `cURL` to download TailwindCSS CLI. - Removed `cURL` from Dockerfile installation.
Hey @AlDu2407 , I wonder if you ever got a chance to add Btw I think it has
|
Hi @matheusgomes28 , is there a way for you to remove the line in the Dockerfile, that removes wget from the build image? I think afterwards the pipeline will succeed. And afterwards you should be able to review the entire code. |
|
||
import "github.com/matheusgomes28/urchin/common" | ||
|
||
templ makeNotFound() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we show the requested resource in the header text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can do later, not an issue
|
||
templ MakeNotFoundPage(links []common.Link) { | ||
@MakeLayout("Not Found", links, makeNotFound()) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line all of these files at the end
+ Make sure we download a particular version of tailwind. + Make sure we do a checksum on the binary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
renderHtml
method to reduce duplicate code in go.about
andservices
.Not Found
handling if a resource is requested that is not present, displaying an error message while keeping the layout page.static
folder to include stylesheets, scripts and assets.