Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#77) DELETE posts requests: #89

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

AlDu2407
Copy link
Contributor

@AlDu2407 AlDu2407 commented May 30, 2024

  • Fixed behaviour when executing multiple DELETE requests for posts.

@AlDu2407 AlDu2407 changed the title (#77) posts: (#77) DELETE posts requests: May 30, 2024
- Fixed behaviour when executing multiple 'DELETE' requests for posts.
@AlDu2407 AlDu2407 force-pushed the issues/77_delete_post branch from 9347320 to b8644c2 Compare May 30, 2024 21:01
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 38.40%. Comparing base (86f0ef8) to head (b8644c2).
Report is 8 commits behind head on main.

Current head b8644c2 differs from pull request most recent head b2eba47

Please upload reports for the commit b2eba47 to get more accurate results.

Files Patch % Lines
database/database.go 0.00% 9 Missing ⚠️
admin-app/post.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   43.42%   38.40%   -5.02%     
==========================================
  Files          16       15       -1     
  Lines         760      716      -44     
==========================================
- Hits          330      275      -55     
- Misses        386      409      +23     
+ Partials       44       32      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlDu2407 AlDu2407 force-pushed the issues/77_delete_post branch from 9b8eae0 to a617e76 Compare May 31, 2024 13:46
Copy link
Owner

@matheusgomes28 matheusgomes28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, thank you very much for the contribution Al! I left some minor comments, I realised that the post add endpoints still work when we remove crucial data like title, excerpt etc.

I'm happy to let these pass for now but I'll create issues to fix that 😄

@AlDu2407
Copy link
Contributor Author

AlDu2407 commented Jun 1, 2024

As usual, thank you very much for the contribution Al! I left some minor comments, I realised that the post add endpoints still work when we remove crucial data like title, excerpt etc.

I'm happy to let these pass for now but I'll create issues to fix that 😄

Let's not merge it then. Let me fix the behaviour of the POST /posts endpoint to behave properly. I wouldn't want to merge something that is half finished.

@AlDu2407 AlDu2407 force-pushed the issues/77_delete_post branch from 304f00a to 3e2fc04 Compare June 1, 2024 12:47
- Updated 'POST /posts' endpoint to handle missing data properly.
- Improved tests for 'POST /posts' and 'DELETE /posts/{id}' endpoints.
@AlDu2407 AlDu2407 force-pushed the issues/77_delete_post branch from 3e2fc04 to b2eba47 Compare June 1, 2024 12:52
@matheusgomes28 matheusgomes28 merged commit 9681a29 into matheusgomes28:main Jun 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants