-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#77) DELETE posts requests: #89
(#77) DELETE posts requests: #89
Conversation
- Fixed behaviour when executing multiple 'DELETE' requests for posts.
9347320
to
b8644c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 43.42% 38.40% -5.02%
==========================================
Files 16 15 -1
Lines 760 716 -44
==========================================
- Hits 330 275 -55
- Misses 386 409 +23
+ Partials 44 32 -12 ☔ View full report in Codecov by Sentry. |
9b8eae0
to
a617e76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As usual, thank you very much for the contribution Al! I left some minor comments, I realised that the post add endpoints still work when we remove crucial data like title, excerpt etc.
I'm happy to let these pass for now but I'll create issues to fix that 😄
Let's not merge it then. Let me fix the behaviour of the |
304f00a
to
3e2fc04
Compare
- Updated 'POST /posts' endpoint to handle missing data properly. - Improved tests for 'POST /posts' and 'DELETE /posts/{id}' endpoints.
3e2fc04
to
b2eba47
Compare
DELETE
requests for posts.