(feat #70) Navbar configuration: #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed fixed links in Urchin. - Added configurable `links` property in Urchin configuration. - Updated application settings to include new links property. - Updated `templ` to add additional parameter for links array. - Updated `app_settings_test`. (fix) Makefile: - Fixed version numbers in `install-tools`.
AlDu2407
force-pushed
the
feat/70_configurable_links
branch
from
7dcd505 to
bfdff1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 43.42% 39.29% -4.13%
==========================================
Files 16 15 -1
Lines 760 799 +39
==========================================
- Hits 330 314 -16
- Misses 386 441 +55
Partials 44 44 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good Al, just need to increase the coverage now for tests.
I'm gonna start enforcing the coverage as we've had PRs from other people in the last couple of weeks that are forgetting to cover the newly added lines in tests, just so we at least have some sort of regression testing.
I believe that `urchin_config.toml` is enough for a configuration file, so we no longer need the env variable configs.
- Fixed minor bug in application start. - Added suggested improvements from PR.
- Fixed tests for app settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linksproperty in Urchin configuration.templto add additional parameter for links array.app_settings_test.(fix) Makefile:
install-tools.