System Tests with full in memory DB support #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusgomes28
commented
Mar 18, 2024
matheusgomes28
force-pushed
the
system-tests-framework
branch
6 times, most recently
from
a37728e to
b003b19
Compare
matheusgomes28
force-pushed
the
system-tests-framework
branch
from
b003b19 to
f23d233
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 24.96% 34.64% +9.68%
==========================================
Files 14 15 +1
Lines 661 713 +52
==========================================
+ Hits 165 247 +82
+ Misses 477 440 -37
- Partials 19 26 +7 ☔ View full report in Codecov by Sentry. |
AlDu2407
pushed a commit
to AlDu2407/urchin
that referenced
this pull request
Mar 22, 2024
This PR implements full system tests / end2end tests using an in memory mysql databse. The motivation for this work was to get coverage for the lines that require a real db connection. These tests are still expensive to run, as the internal DB server needs to be started (~50ms), so only need to have system tests for fully testing a feature. Leave smaller tests for unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements full system tests / end2end tests using an in memory mysql databse. The motivation for this work was to get coverage for the lines that require a real db connection.
These tests are still expensive to run, as the internal DB server needs to be started (~50ms), so only need to have system tests for fully testing a feature. Leave smaller tests for unit tests.