Adding linting steps to CI

.github/workflows/actions/golangci-lint/action.yml

@@ -0,0 +1,12 @@
+name: golangci-lint step
+description: golangci-lint step
+inputs:
+  linter:
+    description: Linter to run
+    required: true
+runs:
+  using: composite
+  steps:
+    - name: Golang CI 2
+      run: golangci-lint run --disable-all -E ${{ inputs.linter }}
+      shell: bash

.github/workflows/build.yml

@@ -11,7 +11,7 @@ jobs:
 
     runs-on: ubuntu-latest
     container:
-      image: mattgomes28/urchin-golang:0.1
+      image: mattgomes28/urchin-golang:0.2
       options: --user 1001
 
     steps:

.github/workflows/failfast.yml

@@ -0,0 +1,39 @@
+name: Fail Fast
+
+on: [workflow_call]
+
+jobs:
+  format-check:
+    runs-on: ubuntu-latest
+    container:
+      image: mattgomes28/urchin-golang:0.2
+      options: --user 1001
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - uses: ./.github/workflows/actions/golangci-lint
+      name: Running errcheck 🧪
+      with:
+        linter: errcheck
+
+    - uses: ./.github/workflows/actions/golangci-lint
+      name: Running staticcheck 🧪
+      with:
+        linter: staticcheck
+
+    - uses: ./.github/workflows/actions/golangci-lint
+      name: Running unused 🧪
+      with:
+        linter: unused
+
+    - uses: ./.github/workflows/actions/golangci-lint
+      name: Running gosimple 🧪
+      with:
+        linter: gosimple
+
+    - uses: ./.github/workflows/actions/golangci-lint
+      name: Running gofmt 🧪
+      with:
+        linter: gofmt
+

.github/workflows/pipeline.yml

@@ -7,11 +7,12 @@ on:
     branches: [ "main" ]
 
 jobs:
-  # failfast:
-  #   uses: ./.github/workflows/failfast.yml
+  failfast:
+    uses: ./.github/workflows/failfast.yml
+
   build:
     uses: ./.github/workflows/build.yml
-    # needs: failfast
+    needs: failfast
   # tests:
   #   uses: ./.github/workflows/test.yml
   #   needs: build

admin-app/app.go

@@ -186,7 +186,12 @@ func Run(app_settings common.AppSettings, database database.Database) error {
 	r.POST("/posts", postPostHandler(&database))
 	r.PUT("/posts", putPostHandler(&database))
 	r.DELETE("/posts", deletePostHandler(&database))
-	r.Run(fmt.Sprintf(":%s", app_settings.WebserverPort))
+
+	err := r.Run(fmt.Sprintf(":%s", app_settings.WebserverPort))
+	if err != nil {
+		log.Error().Msgf("could not run app: %v", err)
+		return err
+	}
 
 	return nil
 }

database/database.go

@@ -2,6 +2,7 @@ package database
 
 import (
 	"database/sql"
+	"errors"
 	"fmt"
 	"time"
 
@@ -82,7 +83,9 @@ func (db *Database) ChangePost(id int, title string, excerpt string, content str
 	if err != nil {
 		return err
 	}
-	defer tx.Rollback()
+	defer func() {
+		err = errors.Join(tx.Rollback())
+	}()
 
 	if len(title) > 0 {
 		_, err := tx.Exec("UPDATE posts SET title = ? WHERE id = ?;", title, id)