Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Laplacian operator for vector fields #380

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Fixing Laplacian operator for vector fields #380

merged 5 commits into from
Nov 18, 2024

Conversation

gc031298
Copy link
Contributor

Solving issue #379

@gc031298 gc031298 marked this pull request as ready for review November 13, 2024 21:59
@dario-coscia dario-coscia added the pr-to-review Label for PR that are ready to been reviewed label Nov 14, 2024
@dario-coscia dario-coscia self-requested a review November 14, 2024 16:52
dario-coscia
dario-coscia requested changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I made some minor comments but it looks good.

Can you also do a small test in test_operators.py for vectorial functions?

pina/operators.py Show resolved Hide resolved
pina/operators.py Show resolved Hide resolved
pina/operators.py Outdated Show resolved Hide resolved
pina/operators.py Show resolved Hide resolved
@dario-coscia dario-coscia added pr-to-fix Label for PR that needs modification and removed pr-to-review Label for PR that are ready to been reviewed labels Nov 15, 2024
dario-coscia
dario-coscia approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it seems very nice, I will merge the PR. I noticed that in test_operator we are not checking the exact value. Maybe let's open a new issue for that. Good job!

@dario-coscia dario-coscia merged commit a78f44e into mathLab:master Nov 18, 2024
16 checks passed
@gc031298 gc031298 deleted the laplacian branch November 19, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-coscia dario-coscia dario-coscia approved these changes

Assignees

@dario-coscia dario-coscia

@gc031298 gc031298

Labels
pr-to-fix Label for PR that needs modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gc031298 @dario-coscia