Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX problem with extra dimension that makes linear interpolation failing #247

Merged
merged 5 commits into from
Nov 15, 2023
Merged

FIX problem with extra dimension that makes linear interpolation failing #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
063013c
FIX problem with extra dimension that makes linear interpolation failing
giovastabile Nov 15, 2023
44cea1d
Update test_linear.py
ndem0 Nov 15, 2023
8f95a84
Update test_linear.py
ndem0 Nov 15, 2023
58cd332
Update test_linear.py
ndem0 Nov 15, 2023
1b6ac68
Update test_linear.py
ndem0 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ezyrb/linear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ def predict(self, new_point):
:return: the interpolated values.
:rtype: numpy.ndarray
"""
return self.interpolator(new_point)
return self.interpolator(new_point).squeeze()
9 changes: 8 additions & 1 deletion tests/test_linear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from unittest import TestCase
from ezyrb import Linear, Database, POD, ReducedOrderModel

class TestKNeighbors(TestCase):
class TestLinear(TestCase):
def test_params(self):
reg = Linear(fill_value=0)
assert reg.fill_value == 0
Expand Down Expand Up @@ -52,6 +52,13 @@ def test_with_db_predict(self):
assert rom.predict([2]) == 5
assert rom.predict([3]) == 3

Y = np.random.uniform(size=(3, 3))
db = Database(np.array([1, 2, 3]), Y)
rom = ReducedOrderModel(db, POD(), Linear())
rom.fit()
assert rom.predict([1.]).shape == (3,)


def test_wrong1(self):
# wrong number of params
with warnings.catch_warnings():
Expand Down
Loading