-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QoL changes to launching server and other fixes #66
base: main
Are you sure you want to change the base?
Conversation
cd95a74
to
5cf9b79
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Thanks Matthew, looks great, but will give test it out next week. |
Thanks, no rush! I'm using this "in production" elsewhere but feel free to make any fixes you see fit |
I ended up overloading this PR with all the bits I needed, but the commits should be thematic and can be reviewed one at a time |
@@ -119,13 +140,26 @@ def get_optimade_config(self): | |||
"debug": False, | |||
"insert_test_data": False, | |||
"insert_from_jsonl": str(jsonl_path.resolve()), | |||
"create_default_index": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be the one bit that is problematic @eimrek -- I added the ability to create a unique ID index to optimade-python-tools which is currently unreleased, when it gets released, serve
will start making a unique index by default, which may conflict with any existing indexes you have... We could always set this to false by default to keep the old behaviour, and user's can now pass it as an env var anyway.
OPTIMAKE_
prefixed env vars