Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix deployment #2

wants to merge 2 commits into from

Conversation

eimrek
Copy link
Member

@eimrek eimrek commented Sep 30, 2024

hi @edan-bainglass, great work on this.

I checked a bit and got the deployment working here: https://materialscloud-org.github.io/discover-sssp-react/

There were some some issues with the base path and build config, fixed.

But an additional issue was that the 150 MB of image files are included directly in the source code. As they are not directly imported, the build process will not include them in dist folder. And including all of them in the frontend (e.g. in the public folder) is not really feasible anyway (it would have to be loaded every time the webpage is accessed).

I currently just directly linked to the raw github URL, when the corresponding data is needed.

Currently i kept the src path, just to demonstrate that it works. But probably, this data should be moved out of the src folder to something like static_data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant