Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @edan-bainglass, great work on this.
I checked a bit and got the deployment working here: https://materialscloud-org.github.io/discover-sssp-react/
There were some some issues with the base path and build config, fixed.
But an additional issue was that the 150 MB of image files are included directly in the source code. As they are not directly imported, the build process will not include them in
dist
folder. And including all of them in the frontend (e.g. in the public folder) is not really feasible anyway (it would have to be loaded every time the webpage is accessed).I currently just directly linked to the raw github URL, when the corresponding data is needed.
Currently i kept the
src
path, just to demonstrate that it works. But probably, this data should be moved out of thesrc
folder to something likestatic_data
.