Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cool Compiler #48

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Cool Compiler #48

wants to merge 44 commits into from

Conversation

JCH97
Copy link

@JCH97 JCH97 commented Feb 26, 2022

No description provided.

JCH97 added 30 commits March 10, 2021 21:53
@JCH97
build(virtual enviroment): set a virtual enviroment
d72a9e7 
A virtual enviroment offers possibility of register all dependencies in project for its later
execution in other enviroment.
@JCH97
feat(lexer): add tools for work in lexer. Intials steps
fa73a25 
Add util folder with auxiliar code needed in all project(AST clases, visitor pattern, ...). Add ply
module for make more easy the coding in this first part. Not complete.
@JCH97
feat(errors): add class for management errors
7e56feb 
introduce management of lexicographic errors
@JCH97
feat(utils): add errors management
14419a1 
init satete for errors managements [only base class and lexicographic errors]
@JCH97
refactor(cool): move lexer and utils into cool folder
9a4270c 
The goal of this change is call with '-m' flag, something like this: 'python -m cool'. This change
allows call cool folder as module and use relative imports with that.
@JCH97
refactor(tokens): change tokens.py, insert token class and update key…
129fca3 
…works/literals
@JCH97
refactor(lexer): update lexer.py, update coolc.h
d2634cd 
Change lexer.py and add good management in ply class.
@JCH97
test(requerimients): add ply in requerimients.txt
5dbdfab
@JCH97
chore(test.utils): print output of subprocess.run for check errors
0cdfe27
@JCH97
fix(coolc): update FILE
04cc872
@JCH97
fix(__main__): add __main__.py in cool module
13de328
@JCH97
revert(test.utils): remove print in utils
64c004c
@JCH97
feat(parser): add initial state for parser. update details into lexer
b170644
@JCH97
chore(parser): test without parser. last test lexer fail
e2b162a
@JCH97
chore(parser): update parser. update __main__.py
3d7ebd0
@JCH97
refactor(parser): remove print(tokens). add parser lines
535992a
@JCH97
refactor(parser): throw exception when catch error into parser
496607d
@JCH97
feat(parser): temporal commit
64471a0
@JCH97
fix(lexer): remove print tokens
957ae58
@JCH97
fix(parser): test commit
4971718
@JCH97
(testing): run lexer tests
5642ec1
@JCH97
(testing): run lexer tests
a3a1345
@JCH97
(feat): remove comments, run parser tests
4574f2b
@JCH97
(feat): set explicit line number after lexer.
870a228
@JCH97
fix(): details
81aa10c
@JCH97
feat(semantic): add initial approach, add typeCollector, set right er…
afdec0a 
…rors managements
@JCH97
fix(several-classes): remove errors from lexer, add right path for te…
c162d96 
…sting file(code.cl)
@JCH97
feat(semantic): add initial approach to typeChecker [not completed], …
8c7020e 
…add new helper functions
@JCH97
fix(semantic): set right imports
50fc21c
@JCH97
feat(semantic): add new types' management
9fc8d22
@jpconsuegra jpconsuegra self-requested a review March 8, 2022 16:03
@jpconsuegra jpconsuegra self-assigned this Mar 8, 2022
@jpconsuegra
Copy link
Collaborator

jpconsuegra commented Mar 8, 2022 •
edited
Loading

Evaluación

  • José Carlos Hernández Piñera
  • Yan Carlos González Blanco
  • Herny Estévez Gómez

Requisitos mínimos (3)

  • El proyecto pasa todos los tests
  • El informe existe y explica el uso del compilador y la arquitectura básica

Requisitos intermedios (4)

  • Se implementaron las fases de chequeo semántico de forma separada y utilizando patrones adecuados
  • La arquitectura del compilador está organizada de forma coherente y mantenible

Requisitos extra (5)

  • Se implementaron las fases de generación de código intermedio y código objeto con patrones adecuados
  • Se resolvieron los problemas de representación de objetos en memoria e invocación de métodos virtuales de forma eficiente
  • Se resolvieron los problemas de boxing/unboxing de forma eficiente
  • Se resuelve el case eficientemente

Comentarios

  • No encontré en el informe cómo resuelven los problemas de boxing/unboxing.
  • No encontré en el informe referencia a como resuelven el case.

Nota final

Evaluación Nota
Final 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpconsuegra jpconsuegra Awaiting requested review from jpconsuegra

Assignees

@jpconsuegra jpconsuegra

Labels
Aprobado Final Finalizado
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JCH97 @jpconsuegra