Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows enable/disable of detections via config file #174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rileydakota
Copy link
Contributor

Wanted to throw this out there to start a discussion on the implementation. I tested with:

  • a disabled detection
  • an enabled detection
  • both enabled and disabled detection

thoughts? Major thing IMO would be that it defaults to false if the key isn't specified, but I believe this is consistent with the docs.

Screenshot 2023-08-09 at 11 14 38 AM
Screenshot 2023-08-09 at 11 15 40 AM

@rileydakota
Copy link
Contributor Author

I am also willing to move this logic to the infra code and just have the decision made to package a detection or not via the CDK. Just wanted to open a PR to start the discussion 😁

@rileydakota
Copy link
Contributor Author

@shaeqahmed @Samrose-Ahmed any chance we could kick off the CI job again, I am a bit confused on why the build failed

@shaeqahmed
Copy link
Contributor

Hey @rileydakota, looks like you might need to rebase since I recently committed a change to fix the broken CI build error you are getting

@rileydakota
Copy link
Contributor Author

@shaeqahmed looks like that did the trick! Would love some feedback on this when you get time :). Totally happy to refactor this to live in the CDK portion of the app versus runtime if that makes more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants