Make transformer able to handle larger files by streaming #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaeqahmed
reviewed
Jun 8, 2023
| download_items: Vec<(DataBatcherOutputRecord, String)>, | ||
| mut stream: Pin<Box<dyn Stream<Item = Result<LineResult, LineError>> + Send>>, | ||
| ) -> Result<( | ||
| Vec<(String, String, String, usize, usize)>, |
There was a problem hiding this comment.
Nit: Too much tuple, should use a struct
There was a problem hiding this comment.
agree its metrics stuff, will do sepretly,
shaeqahmed
approved these changes
Jun 8, 2023
Can handle larger files by buffering and flushing to S3. Signed-off-by: 🐼 Samrose Ahmed 🐼 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can handle larger files by buffering and flushing to S3.
Memory stays low and can handle large files by processing longer.
Timeouts are still an issue, a more optimal approach is to pre split work (even virtually with byte offsets) and have predictable data size. That's a more involved change that will likely not be worked on right now, but this code is still useful.
Related: #155