Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a config option to not explicitly set S3 Block Public Access #125

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Add a config option to not explicitly set S3 Block Public Access #125

merged 1 commit into from
Apr 4, 2023
+28 −10

Conversation

Samrose-Ahmed
Copy link
Contributor

Unblocks users who have org policies preventing usage of s3:PutPublicAccessBlock API (#124).

Usage

Set aws.set_block_public_access as false in matano.config.yml:

# matano.config.yml

aws:
  account: "123456789012"
  region: "us-east-1"
  set_block_public_access: false

@Samrose-Ahmed
Add a config option to not explicitly set S3 Block Public Access
daee999 
Unblocks users who have org policies preventing usage of
s3:PutPublicAccessBlock API (matanolabs#124).

Signed-off-by: 🐼 Samrose Ahmed 🐼 <[email protected]>
@Samrose-Ahmed Samrose-Ahmed mentioned this pull request Apr 4, 2023
Open
shaeqahmed
shaeqahmed approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@shaeqahmed shaeqahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samrose-Ahmed Samrose-Ahmed merged commit b496f6d into matanolabs:main Apr 4, 2023
@Samrose-Ahmed Samrose-Ahmed deleted the s3bpa branch April 4, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaeqahmed shaeqahmed shaeqahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samrose-Ahmed @shaeqahmed