Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/state changes deferred calls 1 #4795

Closed
wants to merge 1 commit into from

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Dec 18, 2024

No description provided.

@sydhds sydhds changed the base branch from main to mainnet_2_3 December 18, 2024 13:52
Copy link
Collaborator

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we handle these differently? (add them together, ...)

        self.effective_total_gas = changes.effective_total_gas;
        self.total_calls_registered = changes.total_calls_registered;

Otherwise, seems fine to me

== other.pos_changes.deferred_credits.credits
&& self.executed_ops_changes == other.executed_ops_changes
&& self.executed_denunciations_changes == other.executed_denunciations_changes
&& self.execution_trail_hash_change == other.execution_trail_hash_change
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&& self.execution_trail_hash_change == other.execution_trail_hash_change
&& self.execution_trail_hash_change == other.execution_trail_hash_change &&
self.deferred_call_changes == other.deferred_call_changes

@sydhds sydhds closed this Jan 2, 2025
@sydhds sydhds deleted the features/state_changes_deferred_calls_1 branch January 2, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants