Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove boostrap whitelist by default #4773

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Remove boostrap whitelist by default #4773

merged 3 commits into from
Nov 20, 2024

Conversation

Leo-Besancon
Copy link
Collaborator

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@Leo-Besancon Leo-Besancon linked an issue Nov 15, 2024 that may be closed by this pull request
Disable bootstrap node whitelisting for v2.4 #4772
Open
@Leo-Besancon Leo-Besancon merged commit 26a7ea8 into mainnet_2_3 Nov 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

@bilboquet bilboquet bilboquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable bootstrap node whitelisting for v2.4
3 participants
@Leo-Besancon @bilboquet @damip