New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add massa event cache crate #4769

Open

sydhds wants to merge 40 commits into mainnet_2_3 from feature/cache_final_event

+3,446 −419

Contributor

sydhds commented Oct 29, 2024

No description provided.

sydhds requested review from damip and bilboquet

October 30, 2024 10:45

sydhds marked this pull request as ready for review

October 30, 2024 10:45

bilboquet reviewed

View reviewed changes

massa-event-cache/src/controller.rs Outdated Show resolved Hide resolved

bilboquet reviewed

View reviewed changes

massa-event-cache/src/controller.rs Outdated Show resolved Hide resolved

bilboquet reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

bilboquet reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

bilboquet reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

bilboquet reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

sydhds requested a review from bilboquet

October 31, 2024 09:53

bilboquet approved these changes

View reviewed changes

bilboquet approved these changes

View reviewed changes

damip reviewed

View reviewed changes

massa-event-cache/src/config.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/config.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/controller.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/event_cache.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/ser_deser.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/ser_deser.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/ser_deser.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-execution-worker/src/execution.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-models/src/output_event.rs Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-node/base_config/config.toml Outdated Show resolved Hide resolved

damip reviewed

View reviewed changes

Member

damip left a comment

Nice !
Made a couple comments, the most important ones are related to security

sydhds added 15 commits

December 10, 2024 14:47


          Improve comment

5dfe45c


          Add query limit

46b1cf7


          Add tick delay in event cache writer thread

350fc7b


          Use per address / operation id / is_error counters

9531a0c


          Cargo fmt

180743f


          typos fixes

1989ee5


          Cargo clippy fixes for tests

31111e3


          Cargo fmt

082e86e


          Add mock expectations + impl

f4b4f81


          Cargo clippy for TU fixes

16bc18d


          Use MAX_EVENT_PER_OPERATION constant

23bfa06


          Unit test the filter optimisations

fe319c5


          Add more doc

d192d2a


          Cargo clippy fixes

db4aa41


          Use ..Default::default in TU

21e3e62

sydhds force-pushed the feature/cache_final_event branch from 025630f to 21e3e62 Compare

December 10, 2024 13:52

sydhds added 6 commits

December 10, 2024 14:55


          Cargo clippy fix

dc817b7


          Use scope

a972ba9


          Use scope 2

c812679


          Remove tick_delay + directly mem::take struct

20af46e


          Add tu for counter removal

59f9300


          Add KeyKind in KeyBuilder

f9d4cf9

damip reviewed

View reviewed changes

massa-event-cache/src/controller.rs Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-event-cache/src/controller.rs Show resolved Hide resolved

damip reviewed

View reviewed changes

massa-node/src/main.rs Outdated Show resolved Hide resolved

sydhds added 2 commits

December 12, 2024 09:57


          Wait for condvar in wait_loop_event

e993258


          Removed unused lib

815bbe3

damip approved these changes

View reviewed changes

Member

damip left a comment •

edited

Loading

Good work on this complicated topic. Testing under load is the last requirement.

sydhds added 2 commits

December 16, 2024 10:05


          Condvar wait fix

955bb8b


          Truncate event message in case of error

0aeb191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1