Checking if the image is hidden before doing anything else

This way we avoid doing unnecessary work in case the image is actually hidden
mashhoodr · Sep 21, 2013 · ebd5ed9 · ebd5ed9
1 parent f8dda0a
commit ebd5ed9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/bower.json b/bower.json
@@ -1,5 +1,5 @@
 {
   "name": "jquery-unveil",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "main": ["jquery.unveil.js"]
 }
diff --git a/jquery.unveil.js b/jquery.unveil.js
@@ -30,13 +30,14 @@
 
     function unveil() {
       var inview = images.filter(function() {
-        var $e = $(this),
-            wt = $w.scrollTop(),
+        var $e = $(this);
+        if ($e.is(":hidden")) return;
+
+        var wt = $w.scrollTop(),
             wb = wt + $w.height(),
             et = $e.offset().top,
             eb = et + $e.height();
 
-        if ($e.is(':hidden')) return;
         return eb >= wt - th && et <= wb + th;
       });