최신순으로 보여주게 수정 #59
Merged
최신순으로 보여주게 수정 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seohyun0120
reviewed
Oct 4, 2024
src/controller/meme.controller.ts
Outdated
|
|
||
| if (size > 5) { | ||
| if (size > 20) { | ||
| return next( | ||
| new CustomError( | ||
| `Invalid 'size' parameter. Today Meme List max size is 5.`, |
There was a problem hiding this comment.
아예 로그도 바꿔버리자
Invalid 'size' parameter. Latest MemeList max size is 20.
src/controller/meme.controller.ts
Outdated
| @@ -164,11 +164,11 @@ const getAllMemeList = async (req: CustomRequest, res: Response, next: NextFunct | |||
| } | |||
| }; | |||
|
|
|||
| const getTodayMemeList = async (req: CustomRequest, res: Response, next: NextFunction) => { | |||
| const getLatestMeme = async (req: CustomRequest, res: Response, next: NextFunction) => { | |||
There was a problem hiding this comment.
이것도 List 뒤에 붙여주세용
getLatestMemeList
src/service/meme.service.ts
Outdated
| @@ -60,27 +60,27 @@ async function getMemeWithKeywords( | |||
| } | |||
| } | |||
|
|
|||
| async function getTodayMemeList( | |||
| async function getLatestCreatedMeme( | |||
| limit: number = 5, | |||
src/service/meme.service.ts
Outdated
| { isDeleted: false, isTodayMeme: true }, | ||
| { isDeleted: 0 }, | ||
| ).lean(); | ||
| const latestMemeList = await MemeModel.find({ isDeleted: false }, { isDeleted: false }) |
There was a problem hiding this comment.
질문) 마지막 필드가 { isDeleted: false} 여도 돼? isDeleted field 제거하겠단거징?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
최신순으로 보여주게 수정
recommend meme 함수 삭제 사용안해서