Upload meme #51
Merged
Upload meme #51
+3,272
−978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjw5521
commented
Sep 25, 2024
•
pjw5521
commented
- s3 업로드
- createMeme api 수정
- deviceId 필드 추가
seohyun0120
reviewed
Sep 26, 2024
src/model/meme.ts
Outdated
| @@ -55,6 +60,7 @@ export interface IMemeDocument extends Document { | |||
|
|
|||
| const MemeSchema: Schema = new Schema( | |||
| { | |||
| deviceId: { type: String, default: '' }, | |||
There was a problem hiding this comment.
여기도
deviceId: { type: String, required: true }
로 변경하고
배포전에 deviceId: 'ADMIN' 으로 일괄 업데이트 해야할 것 같아
deviceId가 ADMIN인 user도 하나 생성하고...
There was a problem hiding this comment.
내가 같이 수정함
DB 마이그레이션은 배포 직전에 다시 한 번 이야기 해봅시다
src/routes/meme.ts
Outdated
Comment on lines
642
to
647
| * keywordIds: | ||
| * type: array | ||
| * items: | ||
| * type: string | ||
| * example: "667fee6dc58681a42d57dc37" | ||
| * description: 밈의 키워드 id 목록 | ||
| * description: "키워드의 ObjectId 배열" | ||
| * description: "등록할 키워드의 ObjectId 목록" |
There was a problem hiding this comment.
swagger에서 테스트해봤는데 keywordIds가 string[]가 아니고 계속 string 형태로 가서 밈 등록이 안되는데 확인 부탁해 swagger 설정 문제인 것 같은데... 좀 찾아봤는데 어떻게 고쳐야할지 모르겠음
[22:42:31.361] INFO (13453): 667fa549239eeaf786f9aa75,667fa3c824fc9c25eaf3b911
keywordIds: req.body.keywordIds.map((id: string) => new Types.ObjectId(id)),
There was a problem hiding this comment.
이거 찾아봐도 안나오네... postman에서는 동작하는 거 확인했으니깐 클라쪽에 말해주고 반영할까 ??
Merged
pjw5521
commented
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.