[Feat] 밈 등록하기 기능 #256
Merged
[Feat] 밈 등록하기 기능 #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvergreenTree97
requested review from
JaesungLeee,
EvergreenTree97,
hj1115hj and
ze-zeh
as code owners
JaesungLeee
approved these changes
Oct 1, 2024
Comment on lines
+76
to
+105
| val contentResolver: ContentResolver = context.contentResolver | ||
| val fileName = getFileName(contentResolver, uri) ?: return null // 파일 이름 얻기 | ||
| val tempFile = File(context.cacheDir, fileName) | ||
|
|
||
| try { | ||
| val inputStream: InputStream? = contentResolver.openInputStream(uri) | ||
| val outputStream: OutputStream = FileOutputStream(tempFile) | ||
|
|
||
| inputStream?.use { input -> | ||
| outputStream.use { output -> | ||
| input.copyTo(output) | ||
| } | ||
| } | ||
| return tempFile | ||
| } catch (e: Exception) { | ||
| e.printStackTrace() | ||
| } | ||
| return null | ||
| } | ||
|
|
||
| private fun getFileName(contentResolver: ContentResolver, uri: Uri): String? { | ||
| val cursor = contentResolver.query(uri, null, null, null, null) | ||
| return cursor?.use { | ||
| if (it.moveToFirst()) { | ||
| val index = it.getColumnIndex("_display_name") | ||
| it.getString(index) | ||
| } else null | ||
| } | ||
| } |
There was a problem hiding this comment.
이렇게 했을 때 실제 fileName이랑 photopicker uri에서 fileName 얻어왔을 때랑 동일해??
There was a problem hiding this comment.
정상 업로드 된것을 봐서는 동일해
JaesungLeee
reviewed
Oct 1, 2024
Comment on lines
+45
to
+50
| val imagePicker = | ||
| rememberLauncherForActivityResult(contract = ActivityResultContracts.PickVisualMedia()) { uri -> | ||
| if (uri != null) { | ||
| onIntent(RegisterIntent.SetImageFromGallery(uri.toString())) | ||
| } | ||
| } |
There was a problem hiding this comment.
각 API Level에 해당하는 권한체크는 없어도 되려나?
<!-- Devices running Android 12L (API level 32) or lower -->
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="32" />
<!-- Devices running Android 13 (API level 33) or higher -->
<uses-permission android:name="android.permission.READ_MEDIA_IMAGES" />
<uses-permission android:name="android.permission.READ_MEDIA_VIDEO" />
<!-- To handle the reselection within the app on Android 14 (API level 34) -->
<uses-permission android:name="android.permission.READ_MEDIA_VISUAL_USER_SELECTED" />
`There was a problem hiding this comment.
https://mundroid.tistory.com/2, https://developer.android.com/training/data-storage/shared/photopicker
따로 권한을 명시하지 않아도 되고, 31버전이하의 경우 문서 선택기로 열린다고 하더라구
커스텀 갤러리가 아니라면 휘뚜루마뚜루 써도 될듯?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내역 (Required)