Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] 마이페이지 QA 수정 #255

Merged
merged 5 commits into from
Sep 30, 2024
Merged

[QA] 마이페이지 QA 수정 #255

merged 5 commits into from
Sep 30, 2024

Conversation

ze-zeh
Copy link
Collaborator

@ze-zeh ze-zeh commented Sep 29, 2024 •
edited
Loading

Issue

작업 내역 (Required)

  • 마이페이지 페이징 적용 안되는 오류 수정
  • 마이페이지 오류 떴을때 새로고침하면 다시 로딩하게 하기
  • MyPage Refresh 했을때 데이터 바뀌면 프로그레스바도 변경하도록 개선

Review Point (Required)

  • none

@ze-zeh ze-zeh self-assigned this Sep 29, 2024
Ricky-Android
Ricky-Android approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@Ricky-Android Ricky-Android left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gOOD!

feature/mypage/src/main/java/team/ppac/mypage/MyPageScreen.kt Outdated Show resolved Hide resolved
@Ricky-Android Ricky-Android marked this pull request as ready for review September 30, 2024 04:17
@ze-zeh ze-zeh merged commit fb0507a into develop Sep 30, 2024
@ze-zeh ze-zeh deleted the qa/mypage branch September 30, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ricky-Android Ricky-Android Ricky-Android approved these changes

@JaesungLeee JaesungLeee JaesungLeee approved these changes

@EvergreenTree97 EvergreenTree97 Awaiting requested review from EvergreenTree97 EvergreenTree97 is a code owner

@hj1115hj hj1115hj Awaiting requested review from hj1115hj hj1115hj is a code owner

Assignees

@ze-zeh ze-zeh

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ze-zeh @JaesungLeee @Ricky-Android