[Feat] 밈 등록 디자인 구현 #249
Merged
[Feat] 밈 등록 디자인 구현 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-zeh
requested review from
JaesungLeee,
EvergreenTree97 and
hj1115hj
as code owners
| text = "Text", | ||
| enabled = false, | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| @Preview | ||
| fun FarmemeMediumChipPreview() { |
There was a problem hiding this comment.
Preview는 private로 숨겨주면 좋을것같아~ ChipPreview가 자동완성에 뜨면 곤란곤란
There was a problem hiding this comment.
과거의 흔적... 전수조사해봐야겟다
| hasImage = false, | ||
| ) | ||
| } | ||
| item { RegisterInputArea() } |
| } | ||
| }, | ||
| bottomBar = { | ||
| RegisterButton( |
There was a problem hiding this comment.
버튼 공중에 떠있는건 스펙인가요?
There was a problem hiding this comment.
예압,, 근데 bottombar에 넣는게 괜찮은지 궁금해요~
EvergreenTree97
approved these changes
Sep 26, 2024
hj1115hj
approved these changes
Sep 26, 2024
| @Composable | ||
| internal fun RegisterCategoryContent( | ||
| modifier: Modifier = Modifier, | ||
| uiModel: RegisterCategoryUiModel, |
| @Composable | ||
| internal fun RegisterCategoryChips( | ||
| modifier: Modifier = Modifier, | ||
| keywords: ImmutableList<String>, |
# Conflicts: # core/designsystem/src/main/kotlin/team/ppac/designsystem/foundation/Icon.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내역 (Required)
Review Point (Required)
Screenshot
1.mp4
관련 링크