[QA] 디테일 스크린 해상도 대응 #239
Merged
[QA] 디테일 스크린 해상도 대응 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hj1115hj
requested review from
JaesungLeee,
EvergreenTree97 and
ze-zeh
as code owners
hj1115hj
force-pushed
the
qa/detail_screen_size
branch
from
20c8919 to
a3b8815
Compare
ze-zeh
approved these changes
Sep 25, 2024
| @@ -26,6 +26,21 @@ data class DetailUiState( | |||
| isError = false, | |||
| isLoading = false, | |||
| ) | |||
|
|
|||
| val PREVIEW_STATE = DetailUiState( | |||
There was a problem hiding this comment.
오 이렇게 preview state 뺴놓는거 좋다~ 참고할게요!!
| @@ -188,7 +201,7 @@ internal fun DetailHashTags( | |||
| shape = FarmemeRadius.Radius4.shape, | |||
| ), | |||
| text = name.truncateDisplayedString(16), | |||
| color = FarmemeTheme.textColor.primary, | |||
| color = if (currentDetailScreenSize == DetailScreenSize.SMALL) FarmemeTheme.textColor.inverse else FarmemeTheme.textColor.primary, | |||
There was a problem hiding this comment.
개인적으로는 textColor 변수로 빼는게 깔끔해 보이더라구요~
There was a problem hiding this comment.
오 깔끔하네용! 리뷰감사해용! 반영완룡!
kyle-lulumedic
approved these changes
Sep 25, 2024
Comment on lines
+7
to
+9
| SMALL(360.dp, 640.dp), | ||
| MEDIUM(360.dp, 800.dp), | ||
| LARGE(430.dp, 932.dp); |
There was a problem hiding this comment.
요 size들은 어떤 기준으로 정해진거야?
뭔가 관련있다면 요고를 참고해봐도 좋을 듯 하기도 하고?
There was a problem hiding this comment.
ui에 적힌 기준이였엉! 오 !! 안드전용으로 다시 바꿔달라구 해야겠다~ 감사합니당 ><
EvergreenTree97
approved these changes
Sep 26, 2024
| LARGE(430.dp, 932.dp); | ||
|
|
||
| companion object { | ||
| fun from(width: Dp, height: Dp): DetailScreenSize { |
There was a problem hiding this comment.
enum class 및 from 함수 정의 좋은데? 직관적이네유~
| @@ -323,11 +339,12 @@ fun DetailFunnyButton( | |||
| fun PreviewDetailContent() { | |||
There was a problem hiding this comment.
Preview Private으로 숨기면 좋을듯~
There was a problem hiding this comment.
앗 까먹구있었당 고마옹!! 반영 완룡!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내역 (Required)
Review Point (Required)
Screenshot
test용으로 W,H dp사이즈 출력했고 commit에서는 지웠어염
https://github.com/user-attachments/assets/672f9221-84de-4003-b031-513a9a1b35fd