Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation 컴포넌트 추가 #34

Merged
merged 8 commits into from
Feb 12, 2022
Merged

Navigation 컴포넌트 추가 #34

merged 8 commits into from
Feb 12, 2022

Conversation

mango906
Copy link
Member

@mango906 mango906 commented Feb 11, 2022 •
edited
Loading

변경사항

  • Naviagation 컴포넌트를 추가하였습니다.
  • 시안 상 사이즈가 있진 않았지만 전역적으로 쓸 헤더, 페이지 안에 들어갈 네비게이션 기준으로 sm, md으로 만들어서 사용하였습니다.
    • 만약 다른 화면에서 또 쓰일 경우 추가적인 개발이 필요할 수 도있는데, 그런 상황이 생기면 대응하기로 합의봤습니다.

작업 유형

  • 신규 기능 추가

체크리스트

  • Merge 할 브랜치가 올바른가?
  • 코딩컨벤션을 준수하였는가?
  • 해당 PR과 관련없는 변경사항이 없는가? (만약 있다면 제목이나 변경사항에 기술하여 주세요.)
  • 실행시 console 창에 에러나 경고가 없는것을 확인하였는가? (개발에 필요하여 고의적으로 남겨둔것 제외)

@mango906 mango906 self-assigned this Feb 11, 2022
@netlify
Copy link

netlify bot commented Feb 11, 2022 •
edited
Loading

✔️ Deploy Preview for affectionate-jones-aa31c6 ready!

🔨 Explore the source changes: c1ae327

🔍 Inspect the deploy log: https://app.netlify.com/sites/affectionate-jones-aa31c6/deploys/6207db927a7e30000792bc0d

😎 Browse the preview: https://deploy-preview-34--affectionate-jones-aa31c6.netlify.app

@mango906 mango906 changed the title Feature/navigation Navigation 컴포넌트 추가 Feb 11, 2022
@mango906
Fix: App.tsx에 불필요한 BrowserRouter 삭제
0a87915 
index.tsx에서 쓰이고 있음
minsour
minsour approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@minsour minsour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dididy
dididy approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@dididy dididy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

HaJunRyu
HaJunRyu approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@HaJunRyu HaJunRyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/components/common/Navigation/Navigation.component.tsx Show resolved Hide resolved
@mango906 mango906 merged commit 629e8c3 into develop Feb 12, 2022
@dididy dididy deleted the feature/navigation branch February 21, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaJunRyu HaJunRyu HaJunRyu approved these changes

@minsour minsour minsour approved these changes

@dididy dididy dididy approved these changes

@Baek2back Baek2back Awaiting requested review from Baek2back Baek2back is a code owner

Assignees

@mango906 mango906

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mango906 @dididy @minsour @HaJunRyu