Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textarea 컴포넌트 추가 #31
Textarea 컴포넌트 추가 #31
Changes from all commits
536fcb6
9b2a1d0
8ee9343
db91cc1
374ffaf
fc16f08
44f2722
87c4940
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TextArea를 common한 컴포넌트로 사용할거라면 resize는 props로 받게끔 해주는것도 좋은것 같아요. 근데 현재 디자인에서 resize되는 textArea가 없다고 한다면 굳이 넣을 필요도 없다고 생각합니다! 디자인쪽이랑 얘기해보고 결정하면 될것 같아요 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아직까진 크게 필요할거 같지않아서, 만약 쓸 상황이 생긴다면 허용해놓도록 하겠습니다!