스케줄 상세주소 추가 작업 #300
Merged
스케줄 상세주소 추가 작업 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for affectionate-jones-aa31c6 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HaJunRyu
approved these changes
Mar 7, 2024
| method: 'GET', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: 'KakaoAK cc4af66dc10aa1a20830f3cc62c40a87', |
There was a problem hiding this comment.
우리 public 레포인데 이건 이렇게 노출해도 되는건가?.?
| @@ -0,0 +1,15 @@ | |||
| import { useEffect } from 'react'; | |||
|
|
|||
| const useScript = (url: string) => { | |||
There was a problem hiding this comment.
해당 hook에서 isScriptLoaded 같은 상태를 관리하고 hook 외부로 헤딩 싱태를 return 해주면 hook의 사용도가 더 올라갈거 같다는 생각!
Comment on lines
+70
to
+71
| const baseAddress = address.replace(/\s*\(.*?\)\s*/g, ''); | ||
| const [, detailAddress] = address.match(/\(([^)]+)\)/) ?? []; |
There was a problem hiding this comment.
이건 내 개인취향인데 정규식은 최대한 하는일에 맞게 이름을 지어주면 코드 파악이나 유지보수 할때 좋은거 같아! 사실 정규식이 한눈에 딱 보고 뭐하는지 알기가 힘드니ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
작업 유형
체크리스트