Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 검색 화면 구현 #33

Merged
merged 3 commits into from
Jun 29, 2024
Merged

feat: 검색 화면 구현 #33

merged 3 commits into from
Jun 29, 2024

Conversation

lina0322
Copy link
Member

What is this PR? 🔍

이슈

#32

설명

검색 화면 구현

Changes 📝

Screenshot 📸

2024-06-30.02.51.46.mov

To Reviewers 🙏

@lina0322 lina0322 self-assigned this Jun 29, 2024
@auto-assign auto-assign bot requested review from chansooo, hryeong66 and jongnan June 29, 2024 18:03
Copy link
Collaborator

@hryeong66 hryeong66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다~!! mim → meme 으로 변경하면 좋을 것 같아요~!

Comment on lines +14 to +16
struct HotKeywordImageView: View, HorizontalMimItemViewProtocol {
typealias Item = HotKeyword

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 PR에 HorizontalMimItemViewProtocol 요거 같이 안올라온거 같은데 맞나용??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

덕분에 해결했어요! 감삼다!

@lina0322 lina0322 merged commit f7d9d37 into develop Jun 29, 2024
3 checks passed
@lina0322 lina0322 deleted the feature/#32 branch June 29, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants