refactor/post: 피드 생성 시 URL open-graph 이미지 url, 요약 상태 필드추가, 전체 피드 조회 시에도 해당 응답 키 값추가 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hye-on
reviewed
Jul 20, 2024
Comment on lines
342
to
+346
| async updatePostClassificationForAIClassification( | ||
| postId: string, | ||
| classificationId: string, | ||
| description: string, | ||
| postAiStatus: PostAiStatus, | ||
| postId: string | null, | ||
| classificationId: string | null, | ||
| description: string | null, |
There was a problem hiding this comment.
postId랑 classificationId null일 경우가 궁금쓰
There was a problem hiding this comment.
ai요약 실패했을경우 null로 올거라 동일한 메서드 사용하면서 status만 변경할 수 있게 나머지 값들은 null도 같이 받을 수 있게 변경했어!
hye-on
reviewed
Jul 20, 2024
Comment on lines
+31
to
+32
| @ApiProperty({ required: false, description: 'URL og 이미지' }) | ||
| thumbnail_img_url: string; |
There was a problem hiding this comment.
오잉 이거 그냥 머지했어?! ㅋㅋㅋ 미안미안 바로 바꿔서 배포하겟음!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
추가 및 변경 사항
PR 중점사항
스크린샷