Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: 온보딩 API 추가 #43

Closed
wants to merge 3 commits into from
Closed

Conversation

J-Hoplin
Copy link
Collaborator

@J-Hoplin J-Hoplin commented Jul 7, 2024

PR 내용

추가 및 변경 사항

  • 온보딩용 API 추가

PR 중점사항

리뷰어가 중점적으로 봐야하는 부분에 대해 적어주세요!

스크린샷

@J-Hoplin J-Hoplin self-assigned this Jul 7, 2024
Copy link
Collaborator

@hye-on hye-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

〆(・∀・@)
온보딩 모듈 따로 만든 이유 궁금쓰
갠적으로 키워드에 넣어도 괜찮을 것 같기두
온보딩이 뭔가 발전될 가능성이 크게 없을 것 같기도 하고
온보딩에서 초기 세팅할 "키워드" 내려주는 api니까??

다른 사람들 의견도 궁금쓰 !!

@JonghunAn
Copy link
Member

JonghunAn commented Jul 11, 2024

로 키워드에 넣어도 괜찮을 것 같기두
온보딩이 뭔가 발전될 가능성이 크게 없을 것 같기도 하고
온보딩에서 초기 세팅할 "키워드" 내려주는 api니까??

onborad 도메인으로 따로 분리하는게 좋을 것 같아~
keyword는 써드파티 ai에서 가져온 정보들이니까!

온보딩시에 필요한 api가 늘어날수도있구~

@J-Hoplin J-Hoplin closed this Jul 13, 2024
@J-Hoplin J-Hoplin mentioned this pull request Jul 13, 2024
@J-Hoplin J-Hoplin deleted the feature/onboard branch July 20, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants