-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI 폴더 추천 고도화 및 요약 Coverage 개선 #106
Conversation
저거 폴더 생성했을 때 폴더 개수랑 폴더목록 조회할때 쿼리 조건값에 visible 판단 쿼리 추가되야하지않아? |
@JonghunAn 음 우선 폴더 API에서 폴더 List 하는 API 하나밖에 영향범위가 없어서 해당 부분은 적용을 해둔 상태고(폴더 Count 하는 부분은 우선 없어), AiClassification 부분에서는 visible 여부 상관 없이 모두 보여줘야하는 상황이라 classification list API에서 visible 필터 안걸어서 가져오도록 해두었어 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 👍 넘 고생했어!!
@@ -32,13 +36,60 @@ export class AiClassificationService { | |||
|
|||
// NOTE: AI 요약 요청 | |||
const start = process.hrtime(); | |||
if (payload.postContent.length < CONTENT_LEAST_LIMIT) { | |||
try { | |||
const puppeteerURL = this.config.get<string>('PUPPETEER_POOL_URL'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
puppeteer 쪽 로직이 별도의 함수나 service로 있으면 어떨까?!
ai classification execute함수에 컨텍스트가 많아서 함수 분리 정도는 해두면 어떨까 하는 생각이 드넹
content정도만 return 해서 본 함수에서 사용하는 식으로?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아무래도 본래 컨텍스트 목적이랑 달라서 형 말대로 분리하는게 더 나을것같당 외부 인프라 통신이기 때문에 infrastructure
에 puppeteer-pool
로 모듈 분리해뒀어! 적용완료!
@@ -76,4 +87,14 @@ export class FolderRepository { | |||
}); | |||
return folders; | |||
} | |||
|
|||
async makeFoldersVisible(folderId: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makeFoldersVisible인데 folderId는 단수당
src/ai_handler.ts
Outdated
@@ -19,6 +20,7 @@ import { AiClassificationService } from './modules/ai-classification/ai-classifi | |||
DatabaseModule, | |||
DiscordModule, | |||
AiModule, | |||
FoldersModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요건 다시 지우면 안되는 모듈이얌?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
삭제해도 괜찮아!
PR 내용
추가 및 변경 사항
마이그레이션(완료상태)
URL Validator 수정
Puppeteer Pool 연결
고도화 기획 사항
PR 중점사항
스크린샷