요약 실패, Input Token 적은 경우에 대한 대응 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Hoplin
requested review from
JonghunAn,
Marades and
hye-on
as code owners
JonghunAn
reviewed
Sep 19, 2024
Comment on lines
+30
to
+34
| tokenCount += 4; | ||
| tokenCount += encoder.encode(message.role).length; | ||
| tokenCount += encoder.encode(message.content).length; | ||
| } | ||
| tokenCount += 2; |
There was a problem hiding this comment.
@J-Hoplin
구문에서 4랑 2 더해주는 이유가 궁금쓰~
그리구 프롬프트에 넣는 role length는 넣은 이유가있어?
파라메터로 받는 content 내용(url 내용 파싱한거)추출 length만으로 판단하면 직관적이고 util 함수도 필요없을 것 같은데!
만약에 필요하다면 reduce를 사용해서 tokenCount 리턴하는것도 좋을듯~
There was a problem hiding this comment.
OpenAI에서 프롬프팅 할때 Function, Role 담은 JSON을 Stringify해서 보내기때문에 그거랑 동일하게 연산하기 위해서 계산하는거로 공유 완료!
| @@ -1 +1,2 @@ | |||
| export const IS_LOCAL = process.env.NODE_ENV === 'local'; | |||
| export const DEFAULT_FOLDER_NAME = '나중에 읽을 링크'; | |||
tsconfig.json
Outdated
| @@ -6,6 +6,7 @@ | |||
| "emitDecoratorMetadata": true, | |||
| "experimentalDecorators": true, | |||
| "allowSyntheticDefaultImports": true, | |||
| "resolveJsonModule": true, | |||
There was a problem hiding this comment.
아 원래 js-tiktoken 말고 tiktoken 사용하려했는데 거기서 JSON을 직접 import 해야되는게 있었어! 지금은 다른 패키지니 지워도 될듯 합니다 ㅎ
src/infrastructure/ai/ai.service.ts
Outdated
| @@ -14,6 +15,7 @@ import { SummarizeURLContent } from './types/types'; | |||
| @Injectable() | |||
| export class AiService { | |||
| private openai: OpenAI; | |||
| private leastTokenThreshold = 300; | |||
There was a problem hiding this comment.
클래스 내의 한 메소드에서만 쓰는데 클래스의 private 멤버 변수로 선언한 이유가 궁금합니당
There was a problem hiding this comment.
그러겡ㅎㅎ 인스턴스 프로퍼티로 들고있을 필요는 없을꺼같아서 변경했어!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 내용
추가 및 변경 사항
success: false플래그와 함께 thumbnail description으로 대체되도록 변경PR 중점사항
안되는 링크들도 있는데 이거는 각 사이트마다 클라우드 프로바이더 IP를 막아서 그런거같아용...
https://stackoverflow.com/questions/59568584/cannot-reach-some-websites-within-aws-lambda-function
스크린샷