handle log entries containing version numbers (since chia 2.4.4) #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that! This regex seems safe to add. Would be nice to add a few more tests (even if not super comprehensive) under tests/chia_log/parsers we have some examples of versioned logs here. For lurkers: It seems that this PR got merged, so there's now also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chia 2.4.4 included a logging format change to insert version numbers prior to the service name.
I've opened Chia-Network/chia-blockchain#18799 (which I don't imagine will be fixed) but also fixed my local chiadog instances.
Here are the fixes which hopefully should work OK with both old and new logging formats - hopefully the regex group is robust enough to handle all possible version strings in future!