Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve day 12 for 2024 #2014

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Solve day 12 for 2024 #2014

wants to merge 2 commits into from

Conversation

martincostello
Copy link
Owner

Solve the puzzle for Advent of Code 2024 day 12.

Solve part 1 of the puzzle for day 12.
@martincostello martincostello added the .NET Pull requests that update .NET code label Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • src/AdventOfCode.Resources/Input/Y2024/Day12/input.txt: Language not supported
Comments skipped due to low confidence (1)

src/AdventOfCode/Puzzles/Y2024/Day12.cs:67

  • The null-forgiving operator '!' is unnecessary here and could lead to unintended behavior. It should be removed.
if (!region.Contains(new(point.X, point.Y + 1))!)
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.39%. Comparing base (3e65e0c) to head (5a2c37e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...AdventOfCode.Site/scripts/ts/puzzles/2024/Day12.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2014   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files         138      138           
  Lines        3530     3530           
  Branches      454      470   +16     
=======================================
  Hits         2132     2132           
  Misses       1398     1398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add skeleton for implementing part 2 for day 12 of 2024.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024 .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants