Merge pull request OpenMathLib#4557 from martin-frbg/4552-2

Fix support for a negative INC_X in the "generic" NRM2 kernels
martin-frbg · Mar 12, 2024 · 42584b4 · 42584b4
2 parents 4a6025a + 6b89e1f
commit 42584b4
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/kernel/arm/nrm2.c b/kernel/arm/nrm2.c
@@ -61,7 +61,7 @@ FLOAT CNAME(BLASLONG n, FLOAT *x, BLASLONG inc_x)
 	if ( n == 1 ) return( ABS(x[0]) );
 
 	n *= inc_x;
-	while(i < n)
+	while(abs(i) < abs(n))
 	{
 
 		if ( x[i] != 0.0 )

diff --git a/kernel/arm/znrm2.c b/kernel/arm/znrm2.c
@@ -62,7 +62,7 @@ FLOAT CNAME(BLASLONG n, FLOAT *x, BLASLONG inc_x)
 	inc_x2 = 2 * inc_x;
 
 	n *= inc_x2;
-	while(i < n)
+	while(abs(i) < abs(n))
 	{
 
 		if ( x[i] != 0.0 )

diff --git a/kernel/mips/nrm2.c b/kernel/mips/nrm2.c
@@ -61,7 +61,7 @@ FLOAT CNAME(BLASLONG n, FLOAT *x, BLASLONG inc_x)
 	if ( n == 1 ) return( ABS(x[0]) );
 
 	n *= inc_x;
-	while(i < n)
+	while(abs(i) < abs(n))
 	{
 
 		if ( x[i] != 0.0 )

diff --git a/kernel/mips/znrm2.c b/kernel/mips/znrm2.c
@@ -53,7 +53,7 @@ FLOAT CNAME(BLASLONG n, FLOAT *x, BLASLONG inc_x)
 	inc_x2 = 2 * inc_x;
 
 	n *= inc_x2;
-	while(i < n)
+	while(abs(i) < abs(n))
 	{
 
 		if ( x[i] != 0.0 )

diff --git a/kernel/riscv64/nrm2.c b/kernel/riscv64/nrm2.c
@@ -61,7 +61,7 @@ FLOAT CNAME(BLASLONG n, FLOAT *x, BLASLONG inc_x)
 	if ( n == 1 ) return( ABS(x[0]) );
 
 	n *= inc_x;
-	while(i < n)
+	while(abs(i) < abs(n))
 	{
 
 		if ( x[i] != 0.0 )

diff --git a/kernel/riscv64/znrm2.c b/kernel/riscv64/znrm2.c
@@ -62,7 +62,7 @@ FLOAT CNAME(BLASLONG n, FLOAT *x, BLASLONG inc_x)
 	inc_x2 = 2 * inc_x;
 
 	n *= inc_x2;
-	while(i < n)
+	while(abs(i) < abs(n))
 	{
 
 		if ( x[i] != 0.0 )