Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PHP to 8.1 in 6.x images #177

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Nov 4, 2023

PHP 8.2.0 was released 08 Dec 2022 (see https://www.php.net/releases/index.php).

This repo uses Renovate and that may already bump these automatically, so let me know if you're explicitly avoiding bumping the version.

EDIT: tests are failing, so maybe that's enough reason to punt the update 😅.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 4, 2023 02:34
@martialblog
Copy link
Owner

Hi, I'm sure we can fix that somehow.

We also should check that LS 5 and 6 support PHP 8.2

@martialblog
Copy link
Owner

From the manual:

PHP version requirements:

    LS 6.x from PHP 7.4.x to 8.1.x
    LS 5.x from PHP 7.2.5 to 8.0.x
    LS 3.x from PHP 5.5.9 to 7.4.x

@edgarrmondragon edgarrmondragon changed the title Bump PHP to 8.2 Bump PHP to 8.2 in 6.x images Nov 4, 2023
@edgarrmondragon edgarrmondragon changed the title Bump PHP to 8.2 in 6.x images Bump PHP to 8.1 in 6.x images Nov 4, 2023
@edgarrmondragon
Copy link
Contributor Author

The apache image test is failing even for 8.1 🤔

@martialblog
Copy link
Owner

Might just be some PHP dependencies. I can have look at it

@martialblog martialblog self-assigned this Nov 9, 2023
@martialblog
Copy link
Owner

Seems as if marking some libraries as manually installed ldd "$(php -r 'echo ini_get("extension_dir");')"/*.so is not working properly here. I'm investigating

@martialblog
Copy link
Owner

@edgarrmondragon I have fix in #178

You should be able to rebase from master and everything should work.

@edgarrmondragon
Copy link
Contributor Author

@edgarrmondragon I have fix in #178

You should be able to rebase from master and everything should work.

@martialblog done!

@martialblog
Copy link
Owner

Awesome. All things green. I'll do some manual testing and then we should be good to go.

Thanks!

@martialblog martialblog merged commit 98db5c6 into martialblog:master Nov 15, 2023
12 checks passed
@martialblog
Copy link
Owner

Merged. Thanks @edgarrmondragon

@edgarrmondragon edgarrmondragon deleted the bump-php branch November 15, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants