supporting piping a buffer to an external process #1204
Conversation
|
Sound good to me! I won't have time to review this until Friday but it seems reasonable given that lua already has the string allocated. Also thanks for adding a test! I need to remember to install |
I added busted to the workflows in #1205. |
Currently only Text objects can be piped to external commands. This is tedious if data not available in any file should be passed to an external process (e.g. building options and passing them to vis-menu). This adds the option to pass a buffer to _vis_pipe and provides wrapper functions for the original behavior and the new one.
Support the old behavior of using vis:pipe(cmd, fullscreen) without input. Properly distinguish between vis:pipe(text, cmd, fullscreen) and vis:pipe(file, range, cmd).
There was a problem hiding this comment.
This all looks good to me and all the tests are great! The vis:pipe is one of the more complicated ones on the C side so its good to make sure all variations are working.
I'm merging with a few minor style tweaks and I squashed the test commits into one.
Thanks for the patch!
|
BTW, does this fix also https://todo.sr.ht/~martanne/vis/5 ? |
Probably yes. |
Alternative to #1177.
There are two major differences:
vis:pipe("string", cmd)is used instead.vis_pipeis extended to support both file and range as well as buffer arguments.Wrapper functions are provided to use the old behavior and the new one with a clean interface.