Update Hare lexer #1170
Closed
Update Hare lexer #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keywords: + enum + union + void Functions: + align + offset Types: + never + nullable + opaque + valist - char - enum - union - void Attributes: + packed + threadlocal - noreturn Additionally, sort everything alphabetically and rename "at rules" to "attributes."
rnpnr
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Thanks for the patch but can you send it to upstream scintillua instead? I will pull it into #1133 once its accepted in scintillua.
|
Ah, okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates keywords to match the current syntax, sorts everything alphabetically, and renames "at rules" to "attributes" as they are named in the specification. Also styles
enumandunionas keywords rather than types to be consistent withstruct, and the same forvoidbecause it has a dual purpose as both a type and a constant.