Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling of statusbar #1168

Merged
merged 1 commit into from
Feb 5, 2024
Merged

allow disabling of statusbar #1168

merged 1 commit into from
Feb 5, 2024

Conversation

apprehensions
Copy link
Contributor

@apprehensions apprehensions commented Feb 1, 2024

fixes #1123

Copy link
Collaborator

@rnpnr rnpnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit on the fence about this one. For a future vis where there is no internal windowing I think this makes sense. As of right now its a bit clunky. For an example open two windows using :split. If the statusbar is off there is no way of distinguishing between the two windows.

I do like that the code is simple and I'm not strictly against the idea.

@apprehensions
Copy link
Contributor Author

If the statusbar is off there is no way of distinguishing between the two windows.

The statusbar disablement is only valid for the selected window. If the user so chooses to disable it on the window, it will be gone, but not on all others.

@mcepl
Copy link
Contributor

mcepl commented Feb 3, 2024

I am not happy about window-managering vis either, but this seems like such a small thing, that I wouldn't bother. Yes, boiling of a frog, I know.

Copy link
Collaborator

@rnpnr rnpnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about some more and unless someone else is extremely objected to this I think its fine. It's a useful feature if you only have 1 window open.

Hopefully we don't get too many reports complaining that they disabled the status bar with two or more windows open and now its not clear which window is focused or where the boundary is.

@rnpnr rnpnr merged commit 243fb87 into martanne:master Feb 5, 2024
24 checks passed
@rnpnr
Copy link
Collaborator

rnpnr commented Feb 5, 2024

Applied, thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabling status line
3 participants