This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Fix attribute name inflection #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attribute name inflection function was applied multiple times to some attributes. For some simple inflection functions this works, because they reach a fixpoint after the first application, e.g. the dasherize function does nothing if the attribute is already dasherized. For other functions, like adding a postfix, this does not work, i.e. for lambda s: s + '_x' would result in an attribute name username_x_x for an attribute called username. Additionally, the inflection was applied to the id field, even though, the id field name must be exactly id.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute name inflection function is applied multiple times to some attributes. For simple inflection functions this works, because they reach a fixpoint after the first application, e.g. the dasherize function does nothing if the attribute is already dasherized.
For other functions, like adding a postfix, this does not work, i.e. for
lambda s: s + '_x'would result in an attribute nameusername_x_xfor an attribute calledusername. Expected would beusername_x.Furthermore, the inflection is applied to the id field, even though, the id field name is dictated by the jsonapi standard. Thus, the predefined fields should not be affected by inflection.
A quick test with the
metashowed, that this problem does not occur here, but other such predefined fields might still be affected by the inflection.