Improved Handling of URLFor Parameters #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 16, 2020 01:09
Add values argument to URLFOR and AbsoluteURLFor to separate between arguments passed to flask.url_for and arguments passed to marshmallow.fields.Field.__init__ with checks to ensure backward compatibility.
Update the documentation to reflect the changes to URLFOR and AbsoluteURLFor
Update the tests to reflect the changes to URLFor and AbsoluteURLFor. Previous tests are kepts to test backward compatiability
|
Thank you for the PR! I'll try to review/merge/release this if I can find some extra time this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issues #52 and #67
I followed the approach proposed by @tinproject here #52 (comment) and used
valuesas the parameter name to be consistent withflask.url_foras suggested by @sloria here #52 (comment)Since implementation does does not depend on the specific parameter names of
flask.url_fornormarshmallow.fields.Field.__init__it should work even if those APIs change. Additionally, checks have been included to ensure backward compatibility (the new field is ignored if it not used).Kindly let me know if any changes are required.
Thank you