Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make benchm yaml work #481

Closed
wants to merge 2 commits into from
Closed

make benchm yaml work #481

wants to merge 2 commits into from

Conversation

lisab00
Copy link
Collaborator

@lisab00 lisab00 commented Sep 29, 2023

part of solving #403

I included "Shared params" in all yaml files. Did have no time to test whether they are working, though.
following files I did not amend, but tested functionality:

  • "benchmark_mnist_shared_hyper_grid.yaml" is working
  • "benchmark_pacs_resnet.yaml" not working (looks like error in diva, rest seems to work)
  • "benchmark_pacs_resnet_on_mnist.yaml" is working
  • "color_mnist_erm_vs_diva.yaml" not working cause no shared params (Carla hopefully fixed this bug, see bugfix if shared params does not exist in yaml #478)

@lisab00 lisab00 marked this pull request as ready for review September 29, 2023 11:10
@smilesun smilesun closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants